Support for hot reloading log levels #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endocrimes
commented
Jul 23, 2019
| @@ -10,7 +10,7 @@ import ( | |||
| // levels that we use. | |||
| func LevelFilter() *logutils.LevelFilter { | |||
| return &logutils.LevelFilter{ | |||
| Levels: []logutils.LogLevel{"TRACE", "DEBUG", "INFO", "WARN", "ERR"}, | |||
| Levels: []logutils.LogLevel{"TRACE", "DEBUG", "INFO", "WARN", "ERROR"}, | |||
There was a problem hiding this comment.
this fixes an existing bug that doesn't allow specifying ERROR level logging as required by hclog (https://github.com/hashicorp/go-hclog/blob/master/logger.go#L59-L76)
endocrimes
force-pushed
the
f-reload-log-level
branch
from
b2e13ea to
0dbebae
Compare
schmichael
approved these changes
Jul 23, 2019
endocrimes
force-pushed
the
f-reload-log-level
branch
from
0dbebae to
2d48ce9
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.