command/agent: LoadConfigDir behavior does not match docs.

[ChrisHines]

// LoadConfigDir loads all the configurations in the given directory
// in alphabetical order.
func LoadConfigDir(dir string) (*Config, error)

This function does not actually sort the files. It uses Readdir to retrieve the list of files.

Readdir reads the contents of the directory associated with file and returns a slice of up to n FileInfo values, as would be returned by Lstat, in directory order.

Running tests on this package on a CentOS 6.6 machine with an ext3 filesystem produces this failure.

--- FAIL: TestConfig_LoadConfigsFileOrder (0.00s)
    config_test.go:331: Loaded configs don't match
        want: [test-resources/etcnomad/common.hcl test-resources/etcnomad/server.json test-resources/myconf]
         got: [test-resources/etcnomad/server.json test-resources/etcnomad/common.hcl test-resources/myconf]

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.