Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alloc lifecycle: 404 when attempting to stop non-existent allocation #5865

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

cgbaker
Copy link
Contributor

@cgbaker cgbaker commented Jun 20, 2019

alloc stop on missing allocation would previously panic

@cgbaker cgbaker requested a review from endocrimes June 20, 2019 21:24
@cgbaker cgbaker force-pushed the b-alloc-stop-missing-panic branch from 111bc94 to 7bc9512 Compare June 20, 2019 21:27
Copy link
Contributor

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🙈

@cgbaker cgbaker merged commit 495e793 into master Jun 21, 2019
@endocrimes endocrimes deleted the b-alloc-stop-missing-panic branch June 21, 2019 11:14
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants