Add config to disable preemption for batch/service jobs #5628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickethier
approved these changes
Apr 30, 2019
api/operator.go
Outdated
| @@ -140,6 +140,8 @@ type SchedulerSetConfigurationResponse struct { | |||
| // PreemptionConfig specifies whether preemption is enabled based on scheduler type | |||
| type PreemptionConfig struct { | |||
| SystemSchedulerEnabled bool | |||
| BatchEnabled bool | |||
There was a problem hiding this comment.
Should these be Batch/ServiceSchedulerEnabled so as to match the SystemScheduledEnabled option?
Also added docs
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds boolean configs to PreemptionConfig struct for batch/service jobs.
Nothing uses these configs yet, that will come in a future PR