Do.Once docker client initialization #556
Conversation
| } | ||
|
|
||
| var err error | ||
| createClient.Do(func() { |
There was a problem hiding this comment.
I'm curious if Once.Do has implications with periodic fingerprinting. For example if we run the fingerprinter once and the client fails because docker is not running yet, does that mean we can't connect later?
There was a problem hiding this comment.
Well if it failed, then we would return false on the fingerprinter anyways so the node wouldn't say it had docker capabilities.
There was a problem hiding this comment.
I thought we ran fingerprinters periodically, though. If so it could fail if nomad starts before Docker, and would then succeed on a subsequent fingerprint pass.
So on the second call I think client would still be nil but the Once.Do would prevent the initialization from firing again.
We would fall through and return nil, nil.
There was a problem hiding this comment.
I thought we ran fingerprinters periodically, though. If so it could fail if nomad starts before Docker, and would then succeed on a subsequent fingerprint pass.
I'm currently using Systemd to make sure Nomad is started after Docker. The same could be done in Upstart. I think that's a fair assumption.
Do.Once docker client initialization
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Only initialize the docker client once to avoid leaking unix domain socket connections to the docker daemon.