Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinct Host constraint accepts bool or string. #501

Merged
merged 2 commits into from
Nov 25, 2015

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Nov 25, 2015

Distinct Host constraint accepts bool or string.

Fixes #489

return err
var enabled bool
var err error
switch value.(type) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract this in a method like toBool? I think it would read better.

dadgar added a commit that referenced this pull request Nov 25, 2015
Distinct Host constraint accepts bool or string.
@dadgar dadgar merged commit 5babe23 into master Nov 25, 2015
@dadgar dadgar deleted the b-distinct-host-panic branch November 25, 2015 23:22
@c4milo
Copy link
Contributor

c4milo commented Nov 27, 2015

@dadgar, I'm curious, why wasn't this constrain handled through the generic constraint configuration? I'm also wondering if having a distinct_datacenter option will make sense within the context of the scheduling algorithms. Or, do you think that by having the scheduling dynamism the need for that type of constrain would be irrelevant.

@dadgar
Copy link
Contributor Author

dadgar commented Nov 27, 2015

The distinct data center is an interesting constraint. It is definitely
something Nomad is capable of. As for why distinct host is treated
differently, the normal constraints actually just restrict feasible nodes
based on their attributes. Distinct nodes restricts based on existing and
planned allocations. There will be more of these types of constraints so it
was easier to separate them.
On Fri, Nov 27, 2015 at 6:14 AM Camilo Aguilar [email protected]
wrote:

@dadgar https://github.com/dadgar, I'm curious, why wasn't this
constrain handled through the generic constraint configuration? I'm also
wondering if having a distinct_datacenter option will make sense within the
context of the scheduling algorithms. Or, do you think that by having the
scheduling dynamism the need for that type of constrain would be irrelevant.


Reply to this email directly or view it on GitHub
#501 (comment).

@diptanu
Copy link
Contributor

diptanu commented Nov 27, 2015

@c4milo @dadgar I think instead of distinct_datacenter, something on the lines of "Balance across DataCenters" is more effective. People usually want the scheduler to run services equally across all the fault domains, for ex: spread the third of workload of a service across every AWS Zones.

One can achieve distinct DCs by having the count same as number of DCs and number of DCs don't change everyday :)

@c4milo
Copy link
Contributor

c4milo commented Nov 30, 2015

@diptanu, right, balancing is what I'm looking for as well. I'm going to create a new issue to keep track of that.

benbuzbee pushed a commit to benbuzbee/nomad that referenced this pull request Jul 21, 2022
@github-actions
Copy link

github-actions bot commented May 2, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants