-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinct Host constraint accepts bool or string. #501
Conversation
return err | ||
var enabled bool | ||
var err error | ||
switch value.(type) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract this in a method like toBool? I think it would read better.
Distinct Host constraint accepts bool or string.
@dadgar, I'm curious, why wasn't this constrain handled through the generic constraint configuration? I'm also wondering if having a distinct_datacenter option will make sense within the context of the scheduling algorithms. Or, do you think that by having the scheduling dynamism the need for that type of constrain would be irrelevant. |
The distinct data center is an interesting constraint. It is definitely
|
@c4milo @dadgar I think instead of distinct_datacenter, something on the lines of "Balance across DataCenters" is more effective. People usually want the scheduler to run services equally across all the fault domains, for ex: spread the third of workload of a service across every AWS Zones. One can achieve distinct DCs by having the count same as number of DCs and number of DCs don't change everyday :) |
@diptanu, right, balancing is what I'm looking for as well. I'm going to create a new issue to keep track of that. |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Distinct Host constraint accepts bool or string.
Fixes #489