Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Escape hatch links on error pages #4850

Merged
merged 5 commits into from
Nov 19, 2018

Conversation

DingoEatingFuzz
Copy link
Contributor

Just a couple simple links to provide somewhere to go after encountering an error.

Closes #4737

image

The impact was the application error was no longer being nulled out,
causing the application error to continue to be shown after
transitioning.

This never happened in apps since it's not possible to transition away
from the error screen.
@DingoEatingFuzz DingoEatingFuzz requested a review from a team November 8, 2018 00:24
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schweet, icing on the cake!

I was going to ask about this with that last error catching PR.

My only comment would be (for a further PR on this). I'm guessing it would be relatively straightforwards to also make this page responsive while you are here?

screen shot 2018-11-08 at 09 10 06

@joshuaogle
Copy link

We've got some very similar empty states coming in the next version of the design system. Glad you were thinking along the same lines!

Not that you need to change anything here, just wanted to give you a heads up. Here are some examples:
image

image

@johncowen
Copy link
Contributor

I'm guessing it would be relatively straightforwards to also make this page responsive while you are here?

Ignore that if you want to just wait until you revisit with these new designs!

@DingoEatingFuzz
Copy link
Contributor Author

@johncowen, good call with the responsiveness. It's dead simple with a design this minimal so I went ahead and added the appropriate styles.

@joshuaogle, I really appreciate the heads up! I like how much lighter the page is, but I think the blue links and the narrow-widths are out of place given the current state of the UI.

image

Looks like this now (keep in mind that the stack trace is a dev feature).

@johncowen
Copy link
Contributor

Thanks for getting this in! Tiniest nit in the world here, but has the central text alignment gone on that 'What you're looking for...' text? Is that on purpose?

@DingoEatingFuzz
Copy link
Contributor Author

Yep. That was to make it more in line with the design system design.

@DingoEatingFuzz DingoEatingFuzz merged commit 654611e into master Nov 19, 2018
@DingoEatingFuzz DingoEatingFuzz deleted the f-ui-links-on-error-pages branch November 19, 2018 20:17
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants