-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Escape hatch links on error pages #4850
Conversation
The impact was the application error was no longer being nulled out, causing the application error to continue to be shown after transitioning. This never happened in apps since it's not possible to transition away from the error screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore that if you want to just wait until you revisit with these new designs! |
@johncowen, good call with the responsiveness. It's dead simple with a design this minimal so I went ahead and added the appropriate styles. @joshuaogle, I really appreciate the heads up! I like how much lighter the page is, but I think the blue links and the narrow-widths are out of place given the current state of the UI. Looks like this now (keep in mind that the stack trace is a dev feature). |
Thanks for getting this in! Tiniest nit in the world here, but has the central text alignment gone on that 'What you're looking for...' text? Is that on purpose? |
Yep. That was to make it more in line with the design system design. |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Just a couple simple links to provide somewhere to go after encountering an error.
Closes #4737