Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Promote canary #4616

Merged
merged 3 commits into from
Aug 30, 2018
Merged

UI: Promote canary #4616

merged 3 commits into from
Aug 30, 2018

Conversation

DingoEatingFuzz
Copy link
Contributor

This is parter of a larger UI Job Writes project #4600

The UI has always shown deployments. Part of this has been informing you when a deployment needs promotion. Now instead of hopping over to a CLI to do the promotion, you can just click a button.

promote-canary

@DingoEatingFuzz DingoEatingFuzz requested a review from a team August 24, 2018 23:40
…tton

Before it would say the deployment required promotion, now it has a
button that triggers the promotion.
@DingoEatingFuzz DingoEatingFuzz mentioned this pull request Aug 24, 2018
5 tasks
Copy link

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple! 👍 There's a linter error to fix (unused later in service-test).

@DingoEatingFuzz
Copy link
Contributor Author

D'oh. Fixed. Waiting for Travis to go green now.

@DingoEatingFuzz DingoEatingFuzz merged commit d824b70 into f-ui-job-writes Aug 30, 2018
@DingoEatingFuzz DingoEatingFuzz deleted the f-ui-promote-canary branch August 30, 2018 16:48
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants