UI: Fix the missing pixels issue with distribution-bar #4507
Conversation
| @@ -76,6 +76,9 @@ export default Component.extend(WindowResizable, { | |||
| const { chart, _data, isNarrow } = this.getProperties('chart', '_data', 'isNarrow'); | |||
| const width = this.$('svg').width(); | |||
| const filteredData = _data.filter(d => d.value > 0); | |||
| filteredData.forEach((d, index) => { | |||
There was a problem hiding this comment.
I read a thing about preference of for ... of over forEach loops recently and have been trying to use them more. I certainly like they way they read, though that's not necessarily true of the transpiled code.
There was a problem hiding this comment.
I always forget that JS has better for loops now.
| // Remove a pixel from either side of the slice | ||
| let modifier = 2; | ||
| if (d.index === 0) modifier--; // But not the left side | ||
| if (d.index === sliceCount - 1) modifier--; // But not the right side |
There was a problem hiding this comment.
These three lines are clever (in a good way).
DingoEatingFuzz
force-pushed
the
b-ui-dist-bar-corners
branch
from
ddd40cb to
d5af5e6
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
These two pixels have been a thorn in my side for a long time.
This fixes two bugs that amount to the same missing pixel issue:
Here are some very subtle before and after screenshots:
Bug 1: A missing pixel on the right side due to wrong indices
before
after
Bug 2: A missing pixel on either side due to subtracting only 1 instead of 2.
before
after
