Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Make task rows clickable. #4387

Merged
merged 1 commit into from
Jun 6, 2018
Merged

UI: Make task rows clickable. #4387

merged 1 commit into from
Jun 6, 2018

Conversation

DingoEatingFuzz
Copy link
Contributor

Right now they are the only tables where the entire row isn't a
click-target to drill into the detail page.

Sidenote: Not sure what I was thinking when I implemented lazyClick the way I did. It isn't actually being used as a helper anywhere, and since it expects an event, I don't see how it would ever work as a helper. Since I'm trying to get this in for 0.8.4, I turned a blind eye to it for the time being.

Right now they are the only tables where the entire row isn't a
click-target to drill into the detail page.
Copy link
Contributor

@meirish meirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one tiny observation though, you may want lazyClick to ignore buttons as well as anchors.

@DingoEatingFuzz DingoEatingFuzz merged commit 4aebd7f into master Jun 6, 2018
@DingoEatingFuzz DingoEatingFuzz deleted the b-ui-task-row-link branch June 6, 2018 22:41
@github-actions
Copy link

github-actions bot commented Mar 2, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants