UI: Node drain and eligibility

[DingoEatingFuzz]

Changes to clients list:

1. Address and Port columns are now merged
2. New drain column with blue text when a node is draining
3. New eligibility column with orange text when a node is ineligible for scheduling

Changes to client detail:

1. New orange status light when a node is ineligible for scheduling
2. Drain and eligibility status in the Client Details information strip
3. New Drain information strip when a node is draining, includes states for
   1. Drain with a deadline
   2. Drain with no deadline
   3. Forced drain

Clients list with a client that is draining

Client detail for a client that is draining with a deadline

Client detail for client that is force-draining (rare to see given the nature of a forced drain)

[alisdair]

This is great! 👍 Just one thought about clarity in the format-duration util.

[alisdair]

I found this part a little tricky to follow. My reading is that the unit of duration can be one of nanoseconds, microseconds, or milliseconds, and for the former two cases we're normalizing it back to milliseconds here.

If that's correct, it might also be clearer to mutate the units argument in these blocks also, rather than in the dense ternary on the following line. And perhaps some commentary explaining this might also help?

[DingoEatingFuzz]

Units can be any unit moment supports (ms, s, m, h, days, months, years) as well as microseconds and nanoseconds, which moment doesn't support.

So this ternary:

  const momentDuration = moment.duration(duration, ['ns', 'mms'].includes(units) ? 'ms' : units);

Uses units as is unless units is either microseconds or nanoseconds, in which case nanos and micros need to be calculated upfront and duration needs to be normalized as milliseconds.

But your suggestion to reassign units to ms is still valid. Also point taken about needing comments.

[meirish]

Not that you need another testing framework, but qunit-dom has been nice to use for tests like this (and you don't need to do all of the trim / includes stuff).

[DingoEatingFuzz]

My testing backlog includes

1. qunit-dom
2. ember-cli-page-object
3. testing unification
4. async/await
5. refactoring how I use mirage now that I know it better

Some day!

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.