Expand drain info for node status command #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preetapan
reviewed
May 4, 2018
command/node_status.go
Outdated
| func (c *NodeStatusCommand) formatNode(client *api.Client, node *api.Node) int { | ||
| // Format the header output | ||
| basic := []string{ | ||
| fmt.Sprintf("ID|%s", limit(node.ID, c.length)), | ||
| fmt.Sprintf("Name|%s", node.Name), | ||
| fmt.Sprintf("Class|%s", node.NodeClass), | ||
| fmt.Sprintf("DC|%s", node.Datacenter), | ||
| fmt.Sprintf("Drain|%v", node.Drain), | ||
| fmt.Sprintf("Drain|%v", nodeDrainString(node)), |
There was a problem hiding this comment.
Could you add a unit test in node_status_test.go?
There was a problem hiding this comment.
Thanks for the reminder! Also renamed it formatDrain to match formatTime.
preetapan
approved these changes
May 4, 2018
schmichael
force-pushed
the
f-expand-drain-info
branch
from
c49f7d0 to
758e1cb
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR
node statusjust displayedDrain = trueorDrain = false.Example of draining node with a deadline and ignoring system jobs:
Example with just a deadline:
Example with no deadline and ignoring system jobs:
Not draining looks the same (just "false"):