Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command: init -short flag #4239

Merged
merged 1 commit into from
May 2, 2018
Merged

command: init -short flag #4239

merged 1 commit into from
May 2, 2018

Conversation

nickethier
Copy link
Member

This PR adds a new flag -short to the job init command which will emit
a minimal jobspec without comments.

preetapan
preetapan approved these changes May 2, 2018
View reviewed changes
Copy link
Contributor

@preetapan preetapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that we would have to remember to add new stanzas to both places which is non ideal, but this is easier to maintain.

@nickethier nickethier merged commit d911a1c into master May 2, 2018
schmichael
schmichael reviewed May 2, 2018
View reviewed changes
command/job_init.go

resources {
cpu = 500 # 500 MHz
memory = 256 # 256MB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these comments to. Just about every job file I see still has them and they're almost always wrong because people tweak the resources without touching the comments 😅

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should leave the units in, but remove the numbers.

schmichael
schmichael reviewed May 2, 2018
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry!

dadgar
dadgar reviewed May 8, 2018
View reviewed changes
command/job_init.go

Init Options:

-short
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to the website: https://www.nomadproject.io/docs/commands/job/init.html

command/job_init.go
datacenters = ["dc1"]

group "cache" {
ephemeral_disk {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the ephemeral disk too

@nickethier nickethier mentioned this pull request May 10, 2018
Merged
@schmichael schmichael mentioned this pull request Jun 18, 2018
Open
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dadgar dadgar dadgar left review comments

@schmichael schmichael schmichael left review comments

@nugend nugend nugend left review comments

@preetapan preetapan preetapan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nickethier @nugend @schmichael @preetapan @dadgar