Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Command Line Groupings #4027

Merged
merged 12 commits into from
Mar 22, 2018
Merged

New Command Line Groupings #4027

merged 12 commits into from
Mar 22, 2018

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Mar 22, 2018

This PR:

  • Moves all our commands into the grouped subcommand pattern
  • Calls out common commands
  • Adds colored output
  • Redirects help to stdout
  • Displays deprecated commands
  • Displays aliased commands in help output
  • Adds more descriptive help output to parent commands (e.g. nomad node)
  • Updates the documentation to the new command format and fixes a lot of inconsistencies

The arguments behave differently depending on the flags given.
See each flag's description for its specific requirements.
The arguments behave differently depending on the flags given. See each
flag's description for its specific requirements.
Copy link
Contributor

@preetapan preetapan Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this old alias client config be mentioned in the docs ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only called out aliases we want to keep. Like shortcuts. We will need to add a version section to: https://www.nomadproject.io/docs/upgrade/upgrade-specific.html

Copy link
Contributor

@preetapan preetapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Its hard to tell if you missed any string search replace spots in the documentation where the old style commands were used, but we can handle that as we see them,

@dadgar dadgar merged commit b1a3e53 into master Mar 22, 2018
@dadgar dadgar deleted the f-common branch March 22, 2018 20:57
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants