chown dirs when migrating ephemeral_disk data #3723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
force-pushed
the
b-3702-chown-dirs
branch
from
e26011f to
50236f7
Compare
dadgar
approved these changes
Jan 8, 2018
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ BUG FIXES: | |||
| * core: Fix search endpoint forwarding for multi-region clusters [[GH-3680](https://github.com/hashicorp/nomad/issues/3680)] | |||
| * core: Fix an issue in which batch jobs with queued placements and lost | |||
| allocations could result in improper placement counts [[GH-3717](https://github.com/hashicorp/nomad/issues/3717)] | |||
| * client: chown directories for migrated `ephemeral_disk`s [GH-3723] | |||
There was a problem hiding this comment.
Migrated ephemeral_disk's maintain directory permissions?
| @@ -499,7 +499,15 @@ func (p *remotePrevAlloc) streamAllocDir(ctx context.Context, resp io.ReadCloser | |||
|
|
|||
| // If the header is for a directory we create the directory | |||
| if hdr.Typeflag == tar.TypeDir { | |||
| os.MkdirAll(filepath.Join(dest, hdr.Name), os.FileMode(hdr.Mode)) | |||
| name := filepath.Join(dest, hdr.Name) | |||
There was a problem hiding this comment.
Yup! Added! Thanks for catching that.
Fixes #3702 Added missing chown call and made it conditional on running as root and not on Windows as we do with files.
schmichael
force-pushed
the
b-3702-chown-dirs
branch
from
50236f7 to
a010d4b
Compare
|
We have tested the patch successfully ! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3702
Added missing chown call and made it conditional on running as root and
not on Windows as we do with files.
50236f7 builds:
linux_amd64.zip
linux_386.zip