Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent absolute URLs in checks paths #3685

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Prevent absolute URLs in checks paths #3685

merged 1 commit into from
Jan 4, 2018

Conversation

filipochnik
Copy link
Contributor

Fixes #3273

@filipochnik
Copy link
Contributor Author

The last check is failing on master too.

schmichael
schmichael approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the MacOS build. Definitely not your problem.

Thanks for the PR!

@schmichael schmichael merged commit 39e08eb into hashicorp:master Jan 4, 2018
schmichael added a commit that referenced this pull request Jan 4, 2018
@schmichael
Add #3685 to changelog
eee9c03
@filipochnik filipochnik deleted the abs-path branch January 4, 2018 19:18
schmichael added a commit that referenced this pull request Jan 9, 2018
@schmichael
Merge pull request #3715 from hashicorp/docs-3685-changelog
727373d 
Add #3685 to changelog
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dadgar dadgar dadgar approved these changes

@schmichael schmichael schmichael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipochnik @schmichael @dadgar