Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Drop timezones from timestamps #3621

Merged
merged 1 commit into from
Dec 6, 2017
Merged

Conversation

DingoEatingFuzz
Copy link
Contributor

All timestamps are displayed in the user's local timezone. In a perfect world, the timezone abbreviations would also be shown to be extra clear. In that same perfect world, JavaScript has a reasonable Date lib.

@DingoEatingFuzz DingoEatingFuzz changed the title UI: Drop timezones from date formats UI: Drop timezones from timestamps Dec 6, 2017
Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems harmless. Looks good to me. Is this because the times are already localized or a UI thing?

@DingoEatingFuzz
Copy link
Contributor Author

The timestamps we use in the UI are all nanos since epoch, therefore timezoneless, therefore localized when cast to a date.

There are some date fields in the API that use an ISO 8601 format which I assume include a timezone, so in the future we'll have to be careful about when and when not to mention a timezone in the UI.

Ideally we would also be consistent with date formats in the API, but nanoseconds make that weird.

@DingoEatingFuzz DingoEatingFuzz merged commit 5acb3e8 into master Dec 6, 2017
@DingoEatingFuzz DingoEatingFuzz deleted the b-ui-timezones branch December 6, 2017 22:16
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants