Handle multiple environment templates #3529
Conversation
client/consul_template.go
Outdated
| @@ -394,7 +394,7 @@ func (tm *TaskTemplateManager) handleTemplateRerenders(allRenderedTime time.Time | |||
| tm.config.Hooks.Kill(consulTemplateSourceName, err.Error(), true) | |||
| return | |||
| } | |||
| tm.config.EnvBuilder.SetTemplateEnv(envMap) | |||
| tm.config.EnvBuilder.MergeTemplateEnv(envMap) | |||
There was a problem hiding this comment.
This is only additive so env vars will never be removed.
I'm unclear why we don't reparse all env templates on any change and simply set the full map each time? That was my intended behavior, and from looking at the code I'm not sure why it doesn't work.
There was a problem hiding this comment.
Ah good point. At first I wanted to avoid reparsing everything but you are right, certain env's may be conditional. Will fix
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #3498