docker: log that a container has been killed by the OOM killer #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: #2203 (at least for Docker tasks)
dadgar
requested changes
Oct 27, 2017
client/driver/docker.go
Outdated
| if ierr != nil { | ||
| h.logger.Printf("[ERR] driver.docker: failed to inspect container %s: %v", h.containerID, ierr) | ||
| } else if container.State.OOMKilled { | ||
| werr = fmt.Errorf("Docker container killed by OOM killer") |
There was a problem hiding this comment.
Can you change the message just to be OOM Killed
|
@multani Awesome! Thank you! |
|
Yay! Thanks! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker has out of the box support for notification when a container has been killed by the OOM killer.
Fix: #2203 (at least for Docker tasks)