Prometheus metrics #3171
Merged
Prometheus metrics #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelseakomlo
force-pushed
the
f-prometheus-metrics
branch
5 times, most recently
from
6f0c28e to
73b05df
Compare
dadgar
reviewed
Sep 8, 2017
command/agent/command.go
Outdated
| @@ -661,6 +662,12 @@ func (c *Command) setupTelemetry(config *Config) (*metrics.InmemSink, error) { | |||
| fanout = append(fanout, sink) | |||
| } | |||
|
|
|||
| // Configure the prometheus sink | |||
| promSink, err := prometheus.NewPrometheusSink() | |||
There was a problem hiding this comment.
This should be behind a config option: https://www.nomadproject.io/docs/agent/configuration/telemetry.html
chelseakomlo
force-pushed
the
f-prometheus-metrics
branch
2 times, most recently
from
2f58a11 to
ce97e92
Compare
Merged
chelseakomlo
force-pushed
the
f-prometheus-metrics
branch
2 times, most recently
from
6f5ab56 to
4f0aa33
Compare
dadgar
approved these changes
Sep 11, 2017
| @@ -92,6 +92,7 @@ acl { | |||
| telemetry { | |||
| statsite_address = "127.0.0.1:1234" | |||
| statsd_address = "127.0.0.1:2345" | |||
| prometheus_metrics = true | |||
| @@ -114,6 +114,15 @@ telemetry { | |||
| } | |||
| ``` | |||
|
|
|||
| ### `prometheus` | |||
|
|
|||
| These `telemetry` parameters apply to | |||
|
|
||
| - `prometheus_metrics` `(bool: false)` - Specifies whether the agent should | ||
| initialize a PrometheusSink, where metrics will be reachable via the metrics | ||
| path `/v1/netrics?format=prometheus`. |
| [Prometheus](https://prometheus.io). | ||
|
|
||
| - `prometheus_metrics` `(bool: false)` - Specifies whether the agent should | ||
| initialize a PrometheusSink, where metrics will be reachable via the metrics |
There was a problem hiding this comment.
Specifies whether the agent should make Prometheus formatted metrics available at /v1/metrics...
|
Changelog too |
chelseakomlo
force-pushed
the
f-prometheus-metrics
branch
2 times, most recently
from
57752f9 to
07fb30e
Compare
chelseakomlo
force-pushed
the
f-prometheus-metrics
branch
from
07fb30e to
34ff818
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Prometheus metrics sink and HTTP endpoint. The endpoint exposes metrics for Prometheus specifically as Prometheus only ingests data via protobuf or text format. See https://prometheus.io/docs/instrumenting/exposition_formats