Parse Docker mounts correctly #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the parsing of Docker mounts and adds testing to ensure no regressions. Fixes #3156
chelseakomlo
approved these changes
Sep 5, 2017
client/driver/docker.go
Outdated
| NoCopy: m.VolumeOptions[0].NoCopy, | ||
| } | ||
|
|
||
| if len(m.VolumeOptions[0].DriverConfig) == 1 { |
There was a problem hiding this comment.
m.VolumeOptions[0] could be assigned to a variable as it is used more than once. Same for m.VolumeOptions[0].DriverConfig[0]
dadgar
added a commit
that referenced
this pull request
Sep 6, 2017
* Parse Docker mounts correctly This PR fixes the parsing of Docker mounts and adds testing to ensure no regressions. Fixes #3156 * Review feedback
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes the parsing of Docker mounts and adds testing to ensure no
regressions.
Fixes #3156