Added dnsoptions to the docker driver #2992
Conversation
|
Weird, first build was successful. Then I fixed a typo in a comment, and the build failed 🤔 |
|
Great, now it builds again. |
client/driver/docker_test.go
Outdated
| @@ -879,6 +880,10 @@ func TestDockerDriver_DNS(t *testing.T) { | |||
| if !reflect.DeepEqual(task.Config["dns_search_domains"], container.HostConfig.DNSSearch) { | |||
| t.Errorf("DNS Servers don't match.\nExpected:\n%s\nGot:\n%s\n", task.Config["dns_search_domains"], container.HostConfig.DNSSearch) | |||
| } | |||
|
|
|||
| if !reflect.DeepEqual(task.Config["dns_options"], container.HostConfig.DNSOptions) { | |||
| t.Errorf("DNS Servers don't match.\nExpected:\n%s\nGot:\n%s\n", task.Config["dns_options"], container.HostConfig.DNSOptions) | |||
There was a problem hiding this comment.
Hardly worth mentioning but looks like there's a copy/paste bug in there. Probably want to change "Servers" to "Options".
There was a problem hiding this comment.
Done! Also updated the text in the statement above for the search_domains which was wrong too.
|
Again CI doesn't build because of other reasons :-( |
|
PR doesn't build because of missing AWS stuff?? |
|
Thanks @decoomanj! Yeah build is breaking because a PR from the other day. Will resolve soon! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
The DnsOptions for Docker were missing.