System jobs should be running until stopped #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit they would be marked as dead if they had no currently running allocations -- even though they would spring back to life (running) if the cluster state changed such that a new eval+alloc was created.
dadgar
approved these changes
Jul 1, 2017
nomad/state/state_store.go
Outdated
| return structs.JobStatusDead, nil | ||
| } | ||
|
|
||
| if hasEval { |
There was a problem hiding this comment.
Lets just remove this and return running after checking if it has been explicitly stopped. The reason is that there could be no allocations (because no eligible nodes) and no evals because they have all garbage collected.
There was a problem hiding this comment.
Ah! Right! I forgot about the gc'd evals case. Updating.
schmichael
force-pushed
the
b-system-jobs-running
branch
from
c647983 to
cd9da16
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit they would be marked as dead if they had no
currently running allocations -- even though they would spring back to
life (running) if the cluster state changed such that a new eval+alloc
was created.