Add new gc_max_allocs tuneable #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More than gc_max_allocs may be running on a node, but terminal allocs will be garbage collected to try to keep the total number below the limit.
schmichael
force-pushed
the
f-gc-alloc-limit
branch
from
84abd9f to
cc11d9a
Compare
dadgar
approved these changes
May 17, 2017
client/config/config.go
Outdated
| @@ -205,6 +209,7 @@ func DefaultConfig() *Config { | |||
| GCParallelDestroys: 2, | |||
| GCDiskUsageThreshold: 80, | |||
| GCInodeUsageThreshold: 70, | |||
| GCMaxAllocs: 200, | |||
| @@ -100,6 +100,12 @@ client { | |||
| - `gc_inode_usage_threshold` `(float: 70)` - Specifies the inode usage percent | |||
| which Nomad tries to maintain by garbage collecting terminal allocations. | |||
|
|
|||
| - `gc_max_allocs` `(int: 200)` - Specifies the maximum number of allocations | |||
|
One failing config test: https://travis-ci.org/hashicorp/nomad/builds/231747600#L3543 |
Went overboard before I realized there's only one test case.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More than gc_max_allocs may be running on a node, but terminal allocs
will be garbage collected to try to keep the total number below the
limit.
The default of 200 allocs was a guess. Let me know if you have a number with more science behind it.
I also split
go gc.run()out of theNewAllocGarbageCollectorfunction as tests were creating and leaking gc goroutines. Not a big deal, but since it's only called one place in runtime code it's not really any convenience to hide it away inside the New func.