[ui] Bugfix: prevent parent job from showing another job's dispatches when it has none #24668
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
24666-in-the-ui-one-job-displays-the-job-launches-of-another
branch
from
5c79ee8 to
9d77d2e
Compare
philrenaud
requested review from
mismithhisler
and removed request for
gulducat
philrenaud
deleted the
24666-in-the-ui-one-job-displays-the-job-launches-of-another
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24666
We had a bug where our
watchChildJobsember concurrency task (which kicks off whenever you hit a parameterized/periodic parent job route) would have a memoized list of childjobs from whenever it was last run. These components are not route-bound, and so don't shed data automatically when their route changes, and since we don't return a[]on /statuses with an ?index=1 parameter, but instead hold the blocking query open for further updates, we don't get any kind of "Clear what the app has in cache" signal.This explicitly clears what the app has in cache on parent job route load.