[ui] Fixes an issue where system jobs' status were set to Scaled Down when their allocs get garbage collected #24620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their allocs get garbage collected
philrenaud
force-pushed
the
b-ui/scaled-down-status-fix-for-system-jobs
branch
from
1c77b2b to
c521fc5
Compare
philrenaud
commented
Dec 6, 2024
| @@ -246,7 +246,7 @@ export default class JobStatusPanelSteadyComponent extends Component { | |||
| } | |||
|
|
|||
| const healthyAllocs = this.allocBlocks.running?.healthy?.nonCanary; | |||
| if (healthyAllocs?.length === totalAllocs) { | |||
| if (healthyAllocs?.length && healthyAllocs?.length === totalAllocs) { | |||
There was a problem hiding this comment.
Specifying that "0 allocs running of your 0 expected allocations!" doesn't mean "healthy"
philrenaud
commented
Dec 6, 2024
| // which is a best-guess-based-on-whats-running number. This means that if there are no current allocs, | ||
| // because they've been GC'd, we don't know if they were deliberately scaled down or failed. | ||
| // Safer in this case to show as failed rather than imply a deliberate scale-down. | ||
| if (totalAllocs === 0 && !this.hasClientStatus) { |
There was a problem hiding this comment.
jobs-index level status comes from this job model computed property
philrenaud
commented
Dec 6, 2024
| @@ -224,7 +224,7 @@ export default class JobStatusPanelSteadyComponent extends Component { | |||
| }; | |||
| } | |||
|
|
|||
| if (this.totalAllocs === 0) { | |||
| if (this.totalAllocs === 0 && !this.job.hasClientStatus) { | |||
There was a problem hiding this comment.
single-job-index-page level status comes from this component computed property
gulducat
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found a fun UI bug today: my system job had allocations fail, and then I worked on something else for several hours, and the garbage collector subsequently removed my terminal allocs.
When viewing the job in the UI, the job showed up as "Scaled Down". This is a new status we added this summer to help show when an operator manually set a job's group counts to 0 to let it sit dormant.
While there are problems with showing an alloc-less system job as "Failed" (it may in fact have been deliberately "scaled down" by virtue of taking all eligible nodes offline, for example), this seems like it's by far the most common reason you'd have an un-GC'd system job with no allocs, and so "Scaled Down" shouldn't be the default label for it. This PR makes it so system/sysbatch jobs cannot be labelled "Scaled Down" as such.