-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Prevent double-open for cmd+click on vars index links #24316
[ui] Prevent double-open for cmd+click on vars index links #24316
Conversation
@philrenaud Perhaps you could provide some guidance here on the build failures I'm encountering? Happy to fix up whatever is busted I'm just a skosh out of my element here. |
Looks good, @ChefAustin ! Thanks for submitting it. I've nudged the Percy tests (visual diff tests / tell us if something moved when it oughtn't have) which are set not to run on forks by default. They should come back soon and if there are visual discrepancies I'll manually review them (flakes sometimes happen with the passage of time) I'd like to ask that you make a changelog entry for this PR — you can run |
Thanks, @philrenaud! Changelog entry has been added in bbb1d9c. |
…orrectly-open-new-tabs Move the dont-open-twice logic into the variable-paths component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, and thank you for the PR!
I pretty much duplicated the fix performed in #23832 but modified it for Vars instead of Jobs.
Not a JS guy so I could be way off-base here.
[Hopefully] Resolves #24315