Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Prevent double-open for cmd+click on vars index links #24316

Conversation

ChefAustin
Copy link
Contributor

I pretty much duplicated the fix performed in #23832 but modified it for Vars instead of Jobs.

Not a JS guy so I could be way off-base here.

[Hopefully] Resolves #24315

@ChefAustin
Copy link
Contributor Author

@philrenaud Perhaps you could provide some guidance here on the build failures I'm encountering?

Happy to fix up whatever is busted I'm just a skosh out of my element here.

[Pictured below: Me being out of my element]
Big Lebowski Out of Your Element Scene

@philrenaud
Copy link
Contributor

Looks good, @ChefAustin ! Thanks for submitting it.

I've nudged the Percy tests (visual diff tests / tell us if something moved when it oughtn't have) which are set not to run on forks by default. They should come back soon and if there are visual discrepancies I'll manually review them (flakes sometimes happen with the passage of time)

I'd like to ask that you make a changelog entry for this PR — you can run make cl from the nomad directory and it should guide you through it.

@ChefAustin
Copy link
Contributor Author

Looks good, @ChefAustin ! Thanks for submitting it.

I've nudged the Percy tests (visual diff tests / tell us if something moved when it oughtn't have) which are set not to run on forks by default. They should come back soon and if there are visual discrepancies I'll manually review them (flakes sometimes happen with the passage of time)

I'd like to ask that you make a changelog entry for this PR — you can run make cl from the nomad directory and it should guide you through it.

Thanks, @philrenaud! Changelog entry has been added in bbb1d9c.

@philrenaud philrenaud self-requested a review October 29, 2024 14:28
philrenaud and others added 2 commits October 29, 2024 15:23
…orrectly-open-new-tabs

Move the dont-open-twice logic into the variable-paths component
Copy link
Contributor

@philrenaud philrenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, and thank you for the PR!

@philrenaud philrenaud added the backport/1.9.x backport to 1.9.x release line label Oct 29, 2024
@philrenaud philrenaud self-assigned this Oct 29, 2024
@philrenaud philrenaud merged commit 3ca7288 into hashicorp:main Oct 29, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI - Cmd/Ctrl + Click bug on Vars table
2 participants