-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drivers: add cwd to exec/java drivers #24249
Conversation
…cwd-to-exec-drivers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great @mismithhisler!
Two big picture items:
- It looks like the ticket didn't include the
java
driver but it's nearly identical to theexec
driver and uses all the same underlying bits. We should probably add that as well. - We're referring to this as the "working directory for the task" but we already document a "task working directory" in the Filesystem docs, which is the directory where Nomad creates the
local/
dir, etc. That directory is the default value ofwork_dir
, isn't it? That leads to a few questions:- Should we use the
work_dir
as part of the binary search path we describe in thecommand
docs? - Is it possible to simply replace the value of the
TaskDir
field with the value ofwork_dir
if set to avoid having an extra field in our protobufs, or does the executor need to know about the fine-grained difference? - How do we disambiguate between the two in our docs?
- Should we use the
@tgross These are all good points.
I'll get this added.
That's a good suggestion.
The executor uses
An idea here is to change |
Eh, come to think of it having the |
Co-authored-by: Tim Gross <[email protected]>
1c88031
to
ddf67de
Compare
2ae0411
to
db5ee6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty straight forward, nice work! Remember to add the backport label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending my comments on the binary blobs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @mismithhisler!
Adds support for setting the working directory in
exec
,raw_exec
, andjava
drivers.Fixes: #2224