identity: adds ability to specify custom filepath for saving workload… #24038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
This looks great @mismithhisler! I've left a couple of minor comments but once you've resolved those and CI is green you're good-to-merge.
mismithhisler
force-pushed
the
workload-identity-filename-param
branch
from
a97778c to
b396110
Compare
mismithhisler
force-pushed
the
workload-identity-filename-param
branch
from
b396110 to
7bea3ce
Compare
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a parameter to identities spec that allows users to specify a custom filepath for persisting workload identities.