Don't exec uname for node attribute kernel.version #2380
Conversation
Previously with client fingerprinting, sys/exec's Command function was being used to execute `uname -r` and the return string processed into the kernel.version node attribute. This change uses gopsutil/host KernelVersion function instead. This means we can drop the os/exec, strings and fmt imports... and not execute an external binary. Signed-off-by: Dave Walker (Daviey) <[email protected]>
client/fingerprint/host.go
Outdated
| @@ -38,11 +35,7 @@ func (f *HostFingerprint) Fingerprint(cfg *config.Config, node *structs.Node) (b | |||
| node.Attributes["kernel.version"] = "" | |||
|
|
|||
| if runtime.GOOS != "windows" { | |||
There was a problem hiding this comment.
KernelVersion will be an empty string on platforms without support so you can remove this guard and set kernel.version above directly.
There was a problem hiding this comment.
OK, i left it there because I assumed it was not an interesting value on Windows, but happy enable it.
There was a problem hiding this comment.
Yeah, I doubt it will ever be interesting on Windows but the fewer runtime.GOOS checks we have the happier I am! :)
Who knows, maybe someday gopsutils will populate a meaningful value for Windows.
Previously, this value was guarded against running on Windows because it called the `uname` command which is unlikely to be there. This change now sets the value from gopsutil, which might well be an empty string. Signed-off-by: Dave Walker (Daviey) <[email protected]>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Previously with client fingerprinting, sys/exec's Command
function was being used to execute
uname -rand the returnstring processed into the kernel.version node attribute.
This change uses gopsutil/host KernelVersion function
instead. This means we can drop the os/exec, strings and
fmt imports... and not execute an external binary.
Signed-off-by: Dave Walker (Daviey) [email protected]