acl: disallow leading / on variable paths
#23757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path for a Variable never begins with a leading `/`, because it's stripped off in the API before it ever gets to the state store. The CLI and UI allow the leading `/` for convenience, but this can be misleading when it comes to writing ACL policies. An ACL policy with a path starting with a leading `/` will never match. Update the ACL policy parser so that we prevent an incorrect variable path in the policy. Fixes: #23730
tgross
force-pushed
the
acl-policy-no-leading-var-slash
branch
from
aab57f2 to
9e4f40c
Compare
tgross
added
theme/acl
type/enhancement
backport/1.8.x
schmichael
approved these changes
Aug 6, 2024
Co-authored-by: Michael Schurter <[email protected]>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path for a Variable never begins with a leading
/, because it's stripped off in the API before it ever gets to the state store. The CLI and UI allow the leading/for convenience, but this can be misleading when it comes to writing ACL policies. An ACL policy with a path starting with a leading/will never match.Update the ACL policy parser so that we prevent an incorrect variable path in the policy.
Fixes: #23730