Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Fix: Actions should pass job id instead of job name #23553

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[ui] Fix: Actions should pass job id instead of job name #23553

merged 1 commit into from
Jul 11, 2024

Conversation

philrenaud
Copy link
Contributor

This makes it so that jobs with a name field that differs from their ID will correctly route an action when run via the web UI.

Resolves #23464

@philrenaud philrenaud requested review from shoenig and gulducat July 11, 2024 17:42
@philrenaud philrenaud self-assigned this Jul 11, 2024
@philrenaud philrenaud linked an issue Jul 11, 2024 that may be closed by this pull request
Nomad action from ui with job name does not work #23464
Closed
@philrenaud philrenaud force-pushed the 23464-nomad-action-from-ui-with-job-name-does-not-work branch from f45ab3e to baa18d1 Compare July 11, 2024 17:42
gulducat
gulducat approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆔

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

Ember Test Audit comparison

main baa18d1 change
passes 1574 1574 0
failures 0 0 0
flaky 0 0 0
duration 11m 27s 999ms 11m 36s 385ms +08s 386ms

@philrenaud philrenaud added the backport/1.8.x backport to 1.8.x release line label Jul 11, 2024
@philrenaud philrenaud merged commit 75722ef into main Jul 11, 2024
18 checks passed
@philrenaud philrenaud deleted the 23464-nomad-action-from-ui-with-job-name-does-not-work branch July 11, 2024 18:55
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jul 11, 2024
Merged
@philrenaud philrenaud mentioned this pull request Jul 11, 2024
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gulducat gulducat gulducat approved these changes

@shoenig shoenig Awaiting requested review from shoenig

Assignees

@philrenaud philrenaud

Labels
backport/1.8.x backport to 1.8.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nomad action from ui with job name does not work
2 participants
@philrenaud @gulducat