Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Cmd/Ctrl + Click won't correctly open new tabs #23544

Closed
dkyanakiev opened this issue Jul 11, 2024 · 3 comments · Fixed by #23832
Closed

UI - Cmd/Ctrl + Click won't correctly open new tabs #23544

dkyanakiev opened this issue Jul 11, 2024 · 3 comments · Fixed by #23832
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/job-summary theme/ui type/bug

Comments

@dkyanakiev
Copy link

dkyanakiev commented Jul 11, 2024

Nomad version

edc56664-71d2-7a63-9574-98f1608a9fdf

Operating system and Environment details

Nomad v1.8.1
BuildDate 2024-06-19T06:43:57Z
Revision 5022543

Issue

In the new version when using the UI, cmd + mouseclick wont correctly open new tabs on the browser.
It both opens the new tab but also changes your current one. This only happens when interacting with the jobs list, which is basically the updated page. Other tabs/menus don't have this problem

Reproduction steps

Open the Jobs list on the UI and try to cmd+click any job. You would see both a new tab but also have your current one change

Expected Result

Open a new tab with the job selected

Actual Result

Screen.Recording.2024-07-11.at.10.53.57.mov
@dkyanakiev dkyanakiev changed the title UI - Command/Ctrl + Click wont correctly open new tabs UI - Cmd/Ctrl + Click wont correctly open new tabs Jul 11, 2024
@dkyanakiev dkyanakiev changed the title UI - Cmd/Ctrl + Click wont correctly open new tabs UI - Cmd/Ctrl + Click won't correctly open new tabs Jul 11, 2024
@jrasell
Copy link
Member

jrasell commented Jul 23, 2024

Hi @dkyanakiev and thanks for raising this issue with the video. I was able to reproduce this locally on main, therefore I will mark this for roadmapping and pass it over to our UI engineer, who will be best placed to assist.

@jrasell jrasell moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage Jul 23, 2024
@jrasell jrasell added theme/job-summary stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Jul 23, 2024
@jrasell jrasell added this to Nomad UI Jul 23, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Nomad UI Jul 23, 2024
@philrenaud
Copy link
Contributor

@dkyanakiev , thanks for raising this — I know exactly what's happening here and I'll get a fix going shortly.

Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/job-summary theme/ui type/bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants