-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Volume Drivers #2351
Docker Volume Drivers #2351
Conversation
This commit adds the functionality to use Docker Volume Drivers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM other than some minor doc cleanups.
# Use named volume created outside nomad. | ||
"name-of-the-volume:/path/in/container" | ||
] | ||
volume_driver = "flocker" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment to draw attention to the volume_driver
field being described.
"/path/on/host:/path/in/container", | ||
|
||
# Use relative paths to rebind paths already in the allocation dir | ||
"relative/to/task:/also/in/container", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these other examples that are already included above as I think the name-of-the-volume
example is the important one when showing how to use volume_driver
Incorporated comments from @schmichael
Hi @schmichael , I just incorporated the changes you suggested. Thanks! |
Perfect! Thanks! |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This commit adds the functionality to use Docker Volume Drivers.