qemu: pass task resources into driver for cgroup setup

[tgross]

As part of the work for 1.7.0 we moved portions of the task cgroup setup down into the executor. This requires that the executor constructor get the TaskConfig.Resources struct, and this was missing from the qemu driver. We fixed a panic caused by this change in #19089 before we shipped, but this fix was effectively undone after we added plumbing for custom cgroups for raw_exec in 1.8.0. As a result, running qemu tasks always fail on Linux.

This was undetected in testing because our CI environment doesn't have QEMU installed. I've got all the unit tests running locally again and have added QEMU installation when we're running the drivers tests, so that'll catch future regressions.

Fixes: #23250

[tgross]

(Holding this in draft pending GitHub Actions getting unstuck so we can run the tests.) Done!

[pkazmierczak]

LGTM!

[djthorpe]

FYI this is also happening to me using the raw_exec driver on nomad 1.8.1

Here is the output in nomad 1.8.1:

Jul 15, '24 13:00:39 +0200 | Driver Failure | failed to launch command with executor: rpc error: code = Unknown desc = unable to configure cgroups: no such file or directory

Here is the snippet from my job:

    task "init" {
      driver = "raw_exec"

      lifecycle {
        sidecar = false
        hook    = "prestart"
      }

      config {
        // Set permissions on the directory
        command = var.data == "" ? "/usr/bin/echo" : "/usr/bin/install"
        args = compact([
          "-d", var.data,
          "-o", "472"
        ])
      }
    } // task "init"

[tgross]

@djthorpe that's because Nomad 1.8.1 doesn't include this PR, as you can see in the changelog. Once the next version of Nomad is released with this patch, please try again. Wait, for raw_exec? Can you open a new issue instead of commenting on a closed PR?

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.