server: fix panic if heartbeat reset happens for GC'd node #23383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
added
type/bug
theme/crash
backport/ent/1.6.x+ent
When setting up the timer for heartbeat invalidation, there's no control that allows us to remove that timer when the node is GC'd. If the GC window is narrow enough, it's possible to GC a node that has a waiting heartbeat timer. In this case, we hit a bug where querying for the node returns `nil` and this is incorrectly handled when checking for disconnect/reconnect state. Fix this bug by correctly handling a `nil` node and allowing the `Node.Update` RPC to fire normally (which then errors correctly). Fixes: #23376 Ref: https://hashicorp.atlassian.net/browse/NET-10109
tgross
force-pushed
the
b-heartbeat-reset-panic
branch
from
7df3c6d to
a46467c
Compare
jrasell
approved these changes
Jun 20, 2024
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up the timer for heartbeat invalidation, there's no control that allows us to remove that timer when the node is GC'd. If the GC window is narrow enough, it's possible to GC a node that has a waiting heartbeat timer. In this case, we hit a bug where querying for the node returns
niland this is incorrectly handled when checking for disconnect/reconnect state. Fix this bug by correctly handling anilnode and allowing theNode.UpdateRPC to fire normally (which then errors correctly).Fixes: #23376
Ref: https://hashicorp.atlassian.net/browse/NET-10109