Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Helios page headers added to the administration section #23366

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

philrenaud
Copy link
Contributor

image

Page headers in the Admin (formerly ACL) section of the UI get the Helios treatment. This being one of the newer sections in the UI, the page title convention was copied over as new sub-sections were added. This standardizes them.

@philrenaud philrenaud requested review from shoenig and tgross June 17, 2024 18:42
@philrenaud philrenaud self-assigned this Jun 17, 2024
View this namespace's <<Hds::Link::Inline @route="jobs" @query={{hash namespace=this.model.name}}>jobs</<Hds::Link::Inline>
or <<Hds::Link::Inline @route="variables" @query={{hash namespace=this.model.name}}>variables</<Hds::Link::Inline>.
</A.Description>
</Hds::Alert>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(PR best reviewed while hiding whitespace changes)

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

github-actions bot commented Jun 17, 2024

Ember Test Audit comparison

main e2cbccd change
passes 1572 1572 0
failures 0 0 0
flaky 0 0 0
duration 11m 24s 884ms 11m 35s 651ms +10s 767ms

@philrenaud philrenaud force-pushed the f-ui/helios-page-titles-in-admin-section branch from ff7c5a8 to e2cbccd Compare June 18, 2024 16:19
@philrenaud philrenaud merged commit b92afa5 into main Jun 18, 2024
15 checks passed
@philrenaud philrenaud deleted the f-ui/helios-page-titles-in-admin-section branch June 18, 2024 16:37
@philrenaud philrenaud added the backport/1.8.x backport to 1.8.x release line label Jun 18, 2024
Copy link

github-actions bot commented Jan 3, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.8.x backport to 1.8.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants