[ui] Add "stopped" as a valid status on jobs index/job detail #23328
+180
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n job model and steady-state panel
tgross
reviewed
Jun 14, 2024
tgross
reviewed
Jun 14, 2024
Ember Test Audit comparison
|
tgross
approved these changes
Jun 14, 2024
philrenaud
force-pushed
the
f-ui/22101-ui-stopped-job-status
branch
from
ccb7dd5 to
a9d61f6
Compare
philrenaud
added a commit
that referenced
this pull request
Jun 17, 2024
* Stopped status passed through to the statuses endpoint and observed on job model and steady-state panel * Status passed to statuses endpoint and test for FE model statuses
philrenaud
added a commit
that referenced
this pull request
Jun 17, 2024
…tail into release/1.8.x (#23338) * no-op commit due to failed cherry-picking * [ui] Add "stopped" as a valid status on jobs index/job detail (#23328) * Stopped status passed through to the statuses endpoint and observed on job model and steady-state panel * Status passed to statuses endpoint and test for FE model statuses --------- Co-authored-by: temp <[email protected]> Co-authored-by: Phil Renaud <[email protected]>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our recent changes to how we label jobs in the UI considers any job "failed" if none of its expected allocations are running or pending, and it's not in active deployment.
This is coincidentally both true for jobs that failed because a user clicked the "stop" button, and also for jobs that failed because of the universe conspiring against us generally.
Luckily, jobs already had a nice
Stopboolean to indicate the manual, deliberate stopping of a job (until it gets garbage collected, and provided it didn't have a "purge" flag passed in).This PR observes that boolean and displays a new "Stopped" status in the UI in two places:
resolves #22101