Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acl: fix validation of ACL plugin policy entries. #23274

Merged
merged 2 commits into from
Jun 10, 2024
Merged

acl: fix validation of ACL plugin policy entries. #23274

merged 2 commits into from
Jun 10, 2024

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Jun 10, 2024 •
edited
Loading

No description provided.

@jrasell jrasell self-assigned this Jun 10, 2024
@jrasell jrasell requested review from tgross and gulducat June 10, 2024 08:36
@jrasell jrasell added backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line labels Jun 10, 2024
@jrasell jrasell marked this pull request as ready for review June 10, 2024 08:37
tgross
tgross approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgross
Copy link
Member

tgross commented Jun 10, 2024

This fixes the bug, but it occurs to me that the example in the docs being pointed out in #23270 is really dubious. There's not really a good reason to give a human user plugin:write, because no HTTP API call for plugins requires plugin:write (they're all read-only endpoints)!

@jrasell
Copy link
Member Author

jrasell commented Jun 10, 2024

This fixes the bug, but it occurs to me that the example in the docs being pointed out in #23270 is really dubious. There's not really a good reason to give a human user plugin:write, because no HTTP API call for plugins requires plugin:write (they're all read-only endpoints)!

Raised #23277 to fix the docs. It's a separate PR, so it's easier to manage the backporting code vs. docs.

@jrasell jrasell merged commit d2a03de into main Jun 10, 2024
31 checks passed
@jrasell jrasell deleted the b-gh-23270 branch June 10, 2024 15:17
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross tgross tgross approved these changes

@gulducat gulducat Awaiting requested review from gulducat

Assignees

@jrasell jrasell

Labels
backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrasell @tgross