Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leader task #2308

Merged
merged 6 commits into from
Feb 14, 2017
Merged

Leader task #2308

merged 6 commits into from
Feb 14, 2017

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Feb 13, 2017

This PR introduces a leader task in a task group. This can be used to gracefully shutdown other tasks within the group when the leader exits.

api/tasks.go Outdated
@@ -163,6 +163,7 @@ type Task struct {
Vault *Vault
Templates []*Template
DispatchPayload *DispatchPayloadConfig
Leader bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a pointer

@@ -358,6 +358,10 @@ The `Task` object supports the following keys:
sends `SIGTERM` if the task doesn't die after the `KillTimeout` duration has
elapsed. The default `KillTimeout` is 5 seconds.

* `leader` - Specifies whether the task is the leader task of the task group. If
Copy link
Contributor

@jippi jippi Feb 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so useful!

@dadgar dadgar merged commit cdce862 into master Feb 14, 2017
@dadgar dadgar deleted the f-leader-task branch February 14, 2017 19:03
@rejeep
Copy link

rejeep commented Feb 14, 2017

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants