-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leader task #2308
Leader task #2308
Conversation
api/tasks.go
Outdated
@@ -163,6 +163,7 @@ type Task struct { | |||
Vault *Vault | |||
Templates []*Template | |||
DispatchPayload *DispatchPayloadConfig | |||
Leader bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this a pointer
@@ -358,6 +358,10 @@ The `Task` object supports the following keys: | |||
sends `SIGTERM` if the task doesn't die after the `KillTimeout` duration has | |||
elapsed. The default `KillTimeout` is 5 seconds. | |||
|
|||
* `leader` - Specifies whether the task is the leader task of the task group. If |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so useful!
❤ |
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR introduces a
leader
task in a task group. This can be used to gracefully shutdown other tasks within the group when the leader exits.