Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: fix panic in job using Vault cluster not in agent config. #22227

Merged
merged 2 commits into from
May 24, 2024
Merged

config: fix panic in job using Vault cluster not in agent config. #22227

merged 2 commits into from
May 24, 2024

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented May 23, 2024

closes #22225

@jrasell jrasell self-assigned this May 23, 2024
@jrasell jrasell requested review from tgross and pkazmierczak May 23, 2024 15:43
@jrasell jrasell added backport/1.7.x backport to 1.7.x release line backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent labels May 23, 2024
tgross
tgross approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nomad/job_endpoint_hook_vault.go Outdated Show resolved Hide resolved
@jrasell jrasell marked this pull request as ready for review May 23, 2024 15:50
@jrasell jrasell added backport/1.8.x backport to 1.8.x release line and removed backport/1.7.x backport to 1.7.x release line labels May 24, 2024
@jrasell jrasell merged commit 81d87f1 into main May 24, 2024
22 checks passed
@jrasell jrasell deleted the b-gh-22225 branch May 24, 2024 14:13
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request May 24, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

@pkazmierczak pkazmierczak Awaiting requested review from pkazmierczak

Assignees

@jrasell jrasell

Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Job Vault stanza inexistent cluster name - nil pointer dereference
2 participants
@jrasell @tgross