Add skip detection for all docker tests #221
Conversation
| @@ -200,6 +200,9 @@ func taskTemplate() *structs.Task { | |||
| } | |||
There was a problem hiding this comment.
Can you add the same to TestDockerDriver_Fingerprint
There was a problem hiding this comment.
This is changed. It should now make sure the fingerprinter applies when it finds docker / java on the system. If docker is missing the fingerprinter should detect this and say it's not there. The fingerprinter should always be run, though. This allows us to verify it does not e.g. panic for silly reasons.
… installed; fix some go vet issues
Add skip detection for all docker tests
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This should fix docker tests failing on OSX, where docker can't be installed