Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix high CPU and FD usage on nomad logs #2079

Merged
merged 5 commits into from
Dec 10, 2016
Merged

Fix high CPU and FD usage on nomad logs #2079

merged 5 commits into from
Dec 10, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Dec 10, 2016 •
edited
Loading

This PR:

  • fixes high CPU and FD usage on nomad logs through better detection of closed connections and by not using time.Tick
  • Generates encode/decode functions for stream frame making it more efficient

Fixes #2024

diptanu
diptanu reviewed Dec 10, 2016
View reviewed changes
command/agent/fs_endpoint.go
@@ -204,6 +205,10 @@ func (s *HTTPServer) FileCatRequest(resp http.ResponseWriter, req *http.Request)
return nil, r.Close()
}

var (
HeartbeatStreamFrame = &StreamFrame{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment

@dadgar dadgar merged commit d9cb132 into master Dec 10, 2016
@dadgar dadgar deleted the b-logs branch December 10, 2016 01:53
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@diptanu diptanu diptanu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tens of thousands of open file descriptors to a single nomad alloc logs directory
2 participants
@dadgar @diptanu