[ui] Fix a bug where promotion would be asked with no new canaries #20408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
b-ui/canary-promotion-should-require-some-new-canaries
branch
from
24238a3 to
a5b4c02
Compare
gulducat
approved these changes
Apr 16, 2024
Ember Test Audit comparison
|
…ore accurately reflect a state of a promotable workflow
philrenaud
force-pushed
the
b-ui/canary-promotion-should-require-some-new-canaries
branch
from
1301e88 to
547cabb
Compare
philrenaud
deleted the
b-ui/canary-promotion-should-require-some-new-canaries
branch
philrenaud
added a commit
that referenced
this pull request
Apr 18, 2024
…20408) * Fix a UI bug where promotion would be asked with no new canaries * Because we now make sure of your allocations, our test cases should more accurately reflect a state of a promotable workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Are all your canaries healthy?" part of the "should we prompt the user to manually promote their deployment" depended on an
array.everycheck without a condition that the array have some members.This meant that, as shown in #20308, a user can run into a situation where a new canary allocation fails to place, but the system insists that "there are no unhealthy canaries!" so it's manual promotion time.
This checks for at least one new-version allocation with canary status that hasn't been rescheduled before flipping
canariesHealthyto true. If there are none, the user will continue to be met with a "Your deployment's canaries are still being health checked" pending status.