Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Fixes an issue where shift+num would not open an eval on the evaluations index table #20047

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

philrenaud
Copy link
Contributor

Because we have multiple links on the Evaluations page table (to open the eval in a sidebar, and also to open the job to which the eval is related), we used a keyboard event "keyup" binding to let a user do something like tab + enter or tab + space to open the sidebar.

This predated the general keyboard navigation convention in the Nomad UI of shift+01, shift+02 to open a list row item action. The "which key was pressed" guard on opening the sidebar prevents this sidebar from opening with shift+n, and this PR fixes that by passing in an explicit "keynav" string on command.

image

Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

github-actions bot commented Feb 28, 2024

Ember Test Audit comparison

main 166d27f change
passes 1549 1549 0
failures 0 0 0
flaky 0 0 0
duration 10m 48s 225ms 10m 44s 165ms -04s 060ms

@philrenaud philrenaud added the backport/1.7.x backport to 1.7.x release line label Feb 28, 2024
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.7.x backport to 1.7.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants