fingerprint: add DNS address and port to Consul fingerprint #19969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
added
theme/consul
theme/consul/connect
tgross
force-pushed
the
fingerprint-consul-dns
branch
from
37c669d to
8f20afc
Compare
gulducat
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
I'm mainly looking for clarification around what exactly the bool return represents on a consulExtractor func, and whether we want to return early on any parse errors encountered along the way as happens here currently, or if we instead want to continue along down the line trying the other options.
other than that, lgtm!
In order to provide a DNS address and port to Connect tasks configured for transparent proxy, we need to fingerprint the Consul DNS address and port. The client will pass this address/port to the iptables configuration provided to the `consul-cni` plugin. Ref: #10628
tgross
force-pushed
the
fingerprint-consul-dns
branch
from
8f20afc to
17688c5
Compare
|
@gulducat I've reworked the logic here a good bit, so that we're not using the |
gulducat
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to provide a DNS address and port to Connect tasks configured for transparent proxy, we need to fingerprint the Consul DNS address and port. The client will pass this address/port to the iptables configuration provided to the
consul-cniplugin.Ref: #10628