Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two issues where settings were not taking effect #199

Merged
merged 1 commit into from
Oct 2, 2015
Merged

Fix two issues where settings were not taking effect #199

merged 1 commit into from
Oct 2, 2015

Conversation

achanda
Copy link
Contributor

@achanda achanda commented Oct 2, 2015

Make sure createHostConfig is called only one

Fixes #196 and #185

Make sure createHostConfig is called only once
0ef12a5 
The second call discards any mods to port binding or
network type

Fixes #185 and #196
@dadgar
Copy link
Contributor

dadgar commented Oct 2, 2015

Nice! Would you mind linking documentation to the net mode? I don't see it: https://docs.docker.com/articles/networking/#container-networking

@achanda
Copy link
Contributor Author

achanda commented Oct 2, 2015

@dadgar my bad, I reverted that commit and squashed.

dadgar added a commit that referenced this pull request Oct 2, 2015
@dadgar
Merge pull request #199 from achanda/double_call
1c6861c 
Fix two issues where settings were not taking effect
@dadgar dadgar merged commit 1c6861c into hashicorp:master Oct 2, 2015
@achanda achanda deleted the double_call branch October 2, 2015 19:43
This was referenced Feb 18, 2022
Open
Open
@github-actions
Copy link

github-actions bot commented May 9, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achanda @dadgar