drivers/raw_exec: enable configuring raw_exec task to have no memory limit #19670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…limit This PR makes it possible to configure a raw_exec task to not have an upper memory limit, which is how the driver would behave pre-1.7. This is done by setting memory_max = -1. The cluster (or node pool) must have memory oversubscription enabled.
gulducat
approved these changes
Jan 9, 2024
| @@ -226,7 +234,11 @@ func (e *UniversalExecutor) configureCG2(cgroup string, command *ExecCommand) { | |||
| // write memory cgroup files | |||
| memHard, memSoft := e.computeMemory(command) | |||
| ed := cgroupslib.OpenPath(cgroup) | |||
| _ = ed.Write("memory.max", strconv.FormatInt(memHard, 10)) | |||
| if memHard == memoryNoLimit { | |||
| _ = ed.Write("memory.max", "max") | |||
There was a problem hiding this comment.
just noting here that "max" is a magic word indicating no limit, ref:
Limits are in the range [0, max] and defaults to "max", which is noop.
shoenig
added a commit
that referenced
this pull request
Jan 11, 2024
…limit (#19670) * drivers/raw_exec: enable configuring raw_exec task to have no memory limit This PR makes it possible to configure a raw_exec task to not have an upper memory limit, which is how the driver would behave pre-1.7. This is done by setting memory_max = -1. The cluster (or node pool) must have memory oversubscription enabled. * cl: add cl
shoenig
added a commit
that referenced
this pull request
Jan 11, 2024
…limit (#19670) (#19690) * drivers/raw_exec: enable configuring raw_exec task to have no memory limit This PR makes it possible to configure a raw_exec task to not have an upper memory limit, which is how the driver would behave pre-1.7. This is done by setting memory_max = -1. The cluster (or node pool) must have memory oversubscription enabled. * cl: add cl Co-authored-by: Seth Hoenig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to configure a raw_exec task to not have an
upper memory limit, which is how the driver would behave pre-1.7.
This is done by setting memory_max = -1. The cluster (or node pool) must
have memory oversubscription enabled.
Closes #19670
Backport to 1.7 so users can re-enable behavior from before.