Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Fix panic when validating non-service reschedule block. #19652

Merged
merged 2 commits into from
Jan 8, 2024
Merged

server: Fix panic when validating non-service reschedule block. #19652

merged 2 commits into from
Jan 8, 2024

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Jan 8, 2024

closes #19644

@jrasell jrasell self-assigned this Jan 8, 2024
@jrasell jrasell added the backport/1.7.x backport to 1.7.x release line label Jan 8, 2024
@jrasell jrasell marked this pull request as ready for review January 8, 2024 10:43
Juanadelacuesta
Juanadelacuesta approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@Juanadelacuesta Juanadelacuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

tgross
tgross approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@tgross tgross left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also checked the 1.6.x code and it looks like this was new in 1.7.x.

@jrasell jrasell merged commit fbea8d1 into main Jan 8, 2024
21 checks passed
@jrasell jrasell deleted the b-gh-19644 branch January 8, 2024 14:14
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juanadelacuesta Juanadelacuesta Juanadelacuesta approved these changes

@tgross tgross tgross approved these changes

@lgfa29 lgfa29 Awaiting requested review from lgfa29

Assignees

@jrasell jrasell

Labels
backport/1.7.x backport to 1.7.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime error: invalid memory address or nil pointer dereference
3 participants
@jrasell @tgross @Juanadelacuesta