[ui] Mask token secret when logged in #19529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es components to Helios
Ember Test Audit comparison
|
philrenaud
force-pushed
the
19525-ui-hide-token-secret-upon-login
branch
from
7518cc1 to
4c63288
Compare
|
I notice that the label for SecretID is kinda crammed up against the bottom of AccessorID. Should we give it a little more headroom? Also, a nitpick for sure, should we make the label text have a space in it? This definitely meets the need tho. |
philrenaud
force-pushed
the
19525-ui-hide-token-secret-upon-login
branch
from
4c63288 to
f2e0331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates some buttons and other components on the sign-in page to the new Helios style
Resolves #19525